Add CustomRegex validation #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trufflesteeeve
approved these changes
Dec 2, 2022
| variables map[string]int | ||
| } | ||
|
|
||
| func NewRegexVarString(original string) RegexVarString { |
There was a problem hiding this comment.
Note: At some point we might want these to error to ensure there isn't any unexpected behavior, but that addition definitely doesn't need to be a part of this PR, and this is great.
There was a problem hiding this comment.
Good point. For now we won't be using these function with the focus being on webhooks, but if/when we do implement templates we'll want to be clear with our errors and warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.