add rabbitmq detector #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustin-decker
approved these changes
Nov 21, 2022
ahrav
reviewed
Nov 21, 2022
| var _ detectors.Detector = (*Scanner)(nil) | ||
|
|
||
| var ( | ||
| keyPat = regexp.MustCompile(`\b(?:amqp:)?\/\/[\S]{3,50}:([\S]{3,50})@[-.%\w\/:]+\b`) |
There was a problem hiding this comment.
suggestion: There look to be a few redundant \ in there for escaping that we can get rid of.
Ex: \b(?:amqp:)?//\S{3,50}:(\S{3,50})@[-.%\w/:]+\b
| matches := keyPat.FindAllStringSubmatch(dataStr, -1) | ||
|
|
||
| for _, match := range matches { | ||
| urlMatch := match[0] |
There was a problem hiding this comment.
suggestion: We should add a len check here for match to prevent any IOOR panics.
if len(match) < 3 {
continue
}
| } | ||
|
|
||
| if verify { | ||
| _, err := amqp.Dial(urlMatch) |
There was a problem hiding this comment.
nit: We can inline this if check since the first return val is unused.
if _, err := amqp.dial(urlmatch); err == nil {
s.Verified = true
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #935
This PR adds a detector for RabbitMQ, where it detects the uri amqp://username:password@host:port
In writing this RabbitMQ detector, I referenced the URI detector code. Feel free to let me know if there's any changes to be made/added!