Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mailchimp detector #909

Merged
merged 2 commits into from Nov 10, 2022
Merged

fixed mailchimp detector #909

merged 2 commits into from Nov 10, 2022

Conversation

ankushgoel27
Copy link
Contributor

Fixed issue with mailchimp detector where valid result was still showing unverified. Now it works fine

Copy link
Contributor

@dustin-decker dustin-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ankushgoel27 !

@dustin-decker dustin-decker merged commit bb0fa05 into trufflesecurity:main Nov 10, 2022
@ankushgoel27
Copy link
Contributor Author

the fix is still not working with sane HTTP client. Need to use the http.DefaultClient.Do. Not sure why the sane HTTP client is not working here

mac2000 pushed a commit to mac2000/trufflehog that referenced this pull request Nov 16, 2022
* fixed mailchimp detector

* Use sane http client

Co-authored-by: Dustin Decker <dustin@trufflesec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants