Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LDAP detector #896

Merged
merged 4 commits into from Nov 19, 2022
Merged

add LDAP detector #896

merged 4 commits into from Nov 19, 2022

Conversation

dustin-decker
Copy link
Contributor

Supports LDAP URIs with separate user and password, and a common MS library.
LDAP supported with non-tls, STARTTLS, and TLS.
Integration test w/ OpenLDAP included.

@dustin-decker dustin-decker requested a review from a team as a code owner November 2, 2022 23:50
mcastorina
mcastorina approved these changes Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Those integration tests look familiar :)

@dustin-decker
Copy link
Contributor Author

Nice! Those integration tests look familiar :)

Yep! They were helpful. We might want to make some of that reusable.

@dustin-decker dustin-decker merged commit ae4b387 into main Nov 19, 2022
@dustin-decker dustin-decker deleted the ldap-detector branch November 19, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dustin-decker @mcastorina