Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to handler #877

Merged
merged 2 commits into from Oct 28, 2022
Merged

Add context to handler #877

merged 2 commits into from Oct 28, 2022

Conversation

bill-rich
Copy link
Collaborator

@bill-rich bill-rich commented Oct 28, 2022 •
edited

Take a context and break if ctx.Done().

@bill-rich bill-rich requested review from a team as code owners October 28, 2022 00:46
mcastorina
mcastorina requested changes Oct 28, 2022
View reviewed changes
pkg/handlers/handlers.go Outdated Show resolved Hide resolved
@bill-rich bill-rich merged commit ab71b93 into main Oct 28, 2022
@bill-rich bill-rich deleted the add_context_to_handler branch October 28, 2022 15:57
@mac2000 mac2000 mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bill-rich @mcastorina