Run chunker in pipeline #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill-rich
force-pushed
the
THOG-771_chunker_in_pipeline
branch
from
f5b8a07
to
3333afa
Compare
pkg/sources/chunker.go
Outdated
| logrus.WithError(err).Error("Error chunking reader.") | ||
| break | ||
| } | ||
| peekData, _ := reader.Peek(common.PeekSize) |
There was a problem hiding this comment.
nit: We should move the PeekSize and ChunkSize variables
There was a problem hiding this comment.
Do you think we should change chunks to have readers instead of []byte for their data?
There was a problem hiding this comment.
I do think it might improve performance a bit and make code cleaner. I'll get a ticket created to track testing and making the change.
dustin-decker
approved these changes
Oct 24, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up oversize chunks as part of the engine pipeline instead of handling it in each source.