[THOG-793] - Return all unverified results #856
Conversation
|
This feels like a change that should be behind a CLI flag if we want to do it. Though |
Yea I agree. So this was actually a common thread in the community slack where users were not getting all the unverified secrets. After talking to Dustin we mainly did this before we had the Dashboard to filter out verified/ non-verified. So with that change in place this was the suggested solution since this would technically be the approach where there we no longer filter out actual unverified results. That being said I think adding a cmd line flag for this makes sense 👍 |
|
It was put in place before we grouped credentials, but we do now, so maybe it is no longer needed? It definitely causes some unexpected behavior. |
|
That seems reasonable. We can always add functionality back in later if we need it. We might want to look into using more of the AWS style custom cleaner for any key/secret detector types, especially if their secrets also match a standard hash. |
I have actually not seen this before. Yea I like this idea. |
|
OKay, I think I actually found a pretty nice solution here. I move out the call to |
| @@ -180,6 +180,7 @@ Flags: | |||
| --concurrency=1 Number of concurrent workers. | |||
| --no-verification Don't verify the results. | |||
| --only-verified Only output verified results. | |||
| --filter-unverified Only output first unverified result per chunk per detector if there are more than one results. | |||
There was a problem hiding this comment.
nitpick: Typo - "more than one results." -> "more than one result."
| concurrency = cli.Flag("concurrency", "Number of concurrent workers.").Default(strconv.Itoa(runtime.NumCPU())).Int() | ||
| noVerification = cli.Flag("no-verification", "Don't verify the results.").Bool() | ||
| onlyVerified = cli.Flag("only-verified", "Only output verified results.").Bool() | ||
| filterUnverified = cli.Flag("filter-unverified", "Only output first unverified result per chunk per detector if there are more than one results.").Bool() |
There was a problem hiding this comment.
nitpick: Typo - "more than one results." -> "more than one result."
* Remove the check to filter and return only a single unverified result. * Revert "Remove the check to filter and return only a single unverified result." This reverts commit 494e432. * Add new CLI flag to filter unverified results.
Remove the check to filter and return only a single unverified result.
#844