Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main.py, truckersmp-cli: Move locale.setlocale() calls to truckersmp-cli #127

Merged
merged 1 commit into from
Nov 15, 2020
Merged

main.py, truckersmp-cli: Move locale.setlocale() calls to truckersmp-cli #127

merged 1 commit into from
Nov 15, 2020

Conversation

kakurasan
Copy link
Collaborator

locale.setlocale() should not be called in Python modules.

I should have fixed this in PR 73.

@kakurasan kakurasan mentioned this pull request Nov 13, 2020
Merged
@Lucki
Copy link
Collaborator

Lucki commented Nov 15, 2020 •
edited

I've found my locale problem but I'm (yet) unable to solve it.
I was testing inside VS Code and the terminal in that IDE gives me a faulty locale.
It works in my normal terminal, so green lights.

Edit: electron/electron#26443

@Lucki Lucki merged commit df10848 into truckersmp-cli:master Nov 15, 2020
@kakurasan kakurasan deleted the move_setlocale branch November 15, 2020 02:25
@kakurasan kakurasan added this to the 0.3.0 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucki Lucki Lucki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kakurasan @Lucki