fix(examples): pageProps is {} by default
#2763
Conversation
marlalain
requested review from
KATT,
trpc-bot and
sachinraja
as code owners
|
Someone is attempting to deploy a commit to the trpc Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It's this the best way to do this or creating a props type would be more useful (as it is a scaffold, too)? |
| @@ -5,7 +5,7 @@ import { trpc } from 'utils/trpc'; | |||
|
|
|||
| const MyApp: AppType = ({ Component, pageProps }) => { | |||
| return ( | |||
| <SessionProvider session={pageProps.session}> | |||
| <SessionProvider session={(pageProps as any).session}> | |||
There was a problem hiding this comment.
We should be able to fix this without any
There was a problem hiding this comment.
@KATT Only if we create a type for it. But this is not intended behavior. next@12.3.1 fixes this. Do I just bump the version?
There was a problem hiding this comment.
Yes we likely need to bump the version on next and next-auth
There was a problem hiding this comment.
It should be
const MyApp: AppType<{ session: Session | null }> = ({ Component, pageProps }) => ...
There was a problem hiding this comment.
I will try bumping the version and if it doesn't work already I will add the type. Is that ok?
There was a problem hiding this comment.
What Julius says above is probably right -- I didn't look into why it started failing, I just noted the issue down
Closes #2754
🎯 Changes
Fixes Next type error (
pagePropsnow is{}by default).✅ Checklist
If necessary, I have added documentation related to the changes made.I have added or updated the tests related to the changes made.