Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v10 next-prisma-starter-websockets example #2685

Merged
merged 14 commits into from Sep 11, 2022
Merged

add v10 next-prisma-starter-websockets example #2685

merged 14 commits into from Sep 11, 2022

Conversation

c-ehrlich
Copy link
Contributor

Relates to #2152

🎯 Changes

Add a full v10 port (no interop) of the next-prisma-starter-websockets example

Builds, passes lint and test, and works fine based on some quick manual testing.

I locked the version of next to 12.2.5 for the time being as there is a type error on the AppRouter until this gets merged into main: vercel/next.js#40391
Once that happens, it should be fine to upgrade to ^12.3.1 or similar.

Also currently the folder name is next-prisma-starter-websockets but the name in package.json is next-starter-websockets. This is how it was in the existing interop example, let me know if you want me to make it consistent, and to what :)

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

(no tests needed changing)

@vercel
Copy link

vercel bot commented Sep 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-prisma-starter ✅ Ready (Inspect) Visit Preview Sep 11, 2022 at 3:18PM (UTC)
www ✅ Ready (Inspect) Visit Preview Sep 11, 2022 at 3:18PM (UTC)

Copy link
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but CI takes a while (#2528) and I gotta run now. Will merge when I get back and add this test to branch protection settings.

Thank you so much! If you setup github sponsors I'll send you some $$$ :)

@KATT KATT merged commit cd8db58 into next Sep 11, 2022
@KATT KATT deleted the v10-ws-sample branch September 11, 2022 20:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants