Svelte import sort #284
Closed
Svelte import sort #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secondfry
commented
Feb 28, 2024
There was a problem hiding this comment.
Reason behind this is jest failing to require an ESM module.
This patch is only applied to dev install, since prettier-plugin-svelte is dev dependency.
secondfry
commented
Feb 28, 2024
| import { vuePreprocessor } from './preprocessors/vue-preprocessor'; | ||
|
|
||
| const { parsers: svelteParsers } = require('prettier-plugin-svelte'); |
There was a problem hiding this comment.
prettier-plugin-svelte@2 works with prettier@2 and has no types. This require is used to skip typing the module.
prettier-plugin-svelte@3 has typings.
|
It does not help with |
|
Apparently I was mistaken – I thought that plugin does not work due to the fact that it didn't sort imports in such scenario: Plugin does indeed work and splits imports into chunks and does not sort around side effect imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.