Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prepare script, consumers should not need to have yarn to be able to install package as a git dependency in package.json #256

Closed

Conversation

scmx
Copy link

@scmx scmx commented Sep 19, 2023

Currently when installing the package it will crash if yarn isn't installed. Because the prepare script runs on consumers machines after install.

Suggested solution: Run tsc directly instead.


Thanks for this nice package by the way! 馃帀

Currently when installing the package it will crash if yarn isn't
installed. Because the prepare script runs on consumers machines after install.

Suggested solution: Run tsc directly instead.
@scmx
Copy link
Author

scmx commented Sep 19, 2023

Had a hard time reproducing this myself. But apparently we had this in package json when the problem occurred (leftover since some earlier point when a problem was fixed in main but not yet published).
"@trivago/prettier-plugin-sort-imports": "github:trivago/prettier-plugin-sort-imports",
and got:
npm ERR! sh: yarn: command not found
Changing to direct npm version solves it. Or installing yarn.
With docker node image yarn is available so no problem there.
馃し

@scmx scmx changed the title Fix prepare script, consumers should not need to have yarn to be able to install package Fix prepare script, consumers should not need to have yarn to be able to install package as a git dependency in package.json Sep 19, 2023
@scmx scmx closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant