Add sort by length option #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to have this! |
|
I also would love to have this. When it will be on the prod guys? |
juanrfigueiredo
approved these changes
Aug 29, 2023
|
Had to update the branch, think it needs reaproving |
juanrfigueiredo
approved these changes
Sep 11, 2023
|
If this gets merged prettier can be renamed prettiest :) |
|
+1 for this, could we merge it? |
|
Gonna need someone to approve and merge it, keep coming back to it approved with merge blocks |
annesnour03
reviewed
Nov 15, 2023
Co-authored-by: annes <76728727+annesnour03@users.noreply.github.com>
|
@annesnour03 can you approve so I can get this put away |
annesnour03
approved these changes
Nov 15, 2023
|
I still cant merge it @annesnour03 so idk if you can if not... it waits even more XD |
|
|
|
@ayusharma @byara come to our rescue please! |
|
Any news on this :)? @ayusharma & @byara |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to be able to sort within import groups by length mentioned #76, choices are
ascshortest to longestdesclongest to shortestnullno length rule appliedAfter length imports are sorted alphabetically
I have an internal fork with this implemented already so this doesn't affect me, but this is the general setup I have been using