Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump nightly version to fix the test suite #542

Merged
merged 1 commit into from
May 2, 2024

Conversation

CosmicHorrorDev
Copy link
Contributor

serde made a release adding support for saturating types that fails to compile on the specific nightly that's currently set as public_api::MINIMUM_NIGHTLY_RUST_VERSION and it can't be fixed at this point without breaking backwards compat. This PR bumps the nightly version used for the public API check to the first one that starts compiling successfully again

Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Bonus points for the sanity check.

@Enselic Enselic merged commit b2a8ebe into trishume:master May 2, 2024
4 checks passed
@CosmicHorrorDev CosmicHorrorDev deleted the nightly-pain branch May 3, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants