Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cargo fmt to CI, run initial format #528

Merged
merged 3 commits into from Apr 5, 2024
Merged

Conversation

syphar
Copy link
Contributor

@syphar syphar commented Apr 5, 2024

Coming from the comment by @Enselic in #526: #526 (comment)

I agree with should rustfmt all code and enforce it in CI though. More or less all other projects in the Rust ecosystem does that, and the upsides far outweighs the downside IMHO.

I also added the initial format commit to the ignore-blame file: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Bonus points for .git-blame-ignore-revs.

I've brought this up every now and then and have heard no strong objections from other maintainers.

Let's merge!

@Enselic Enselic merged commit 53413d5 into trishume:master Apr 5, 2024
4 checks passed
@syphar syphar deleted the rustfmt branch April 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants