Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing of gutterSettings #506

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Add parsing of gutterSettings #506

merged 2 commits into from
Feb 7, 2024

Conversation

timhillgit
Copy link
Contributor

Many TextMate2 themes use gutterSettings to store colors for the gutter area. This is not supported by Sublime Text. This PR enables using gutterSettings to set the foreground and background of the gutter but only if they are not already set in settings.

Closes #469

@keith-hall
Copy link
Collaborator

Looks good to me. Probably it would also make sense to update the unit tests at

fn can_parse_common_themes() {
to prove it parses it as expected.

@timhillgit
Copy link
Contributor Author

Ah, that's a good idea, I was only looking at theme_load so I missed it. I'll add that in.

@timhillgit
Copy link
Contributor Author

@keith-hall Are there any more unit tests or anything else you'd like to see before this is merged?

@Enselic Enselic merged commit f665482 into trishume:master Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for gutterSettings
3 participants