Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate checking 'last 3 Rust versions' on CI #483

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jul 4, 2023

This PR replaces unmaintained actions/toolchain with dtolnay/rust-toolchain. It is well-maintained and supports 'stable minus N releases' syntax to specify toolchain version so that we don't need to maintain the MIN_SUPPORTED_RUST_VERSION variable manually. In addition, I updated actions/checkout since v2 seems no longer maintained in favor of v3.

I confirmed all jobs passed by this PR: https://github.com/rhysd/syntect/actions/runs/5453682953

Current master branch failed since Rust version was too old for some dependencies.

Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement👍

@Enselic
Copy link
Collaborator

Enselic commented Jul 21, 2023

This PR makes CI more green than running from master, so let's merge.

@Enselic Enselic merged commit b8f7eb6 into trishume:master Jul 21, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants