yaml_load.rs: Propagate FromUtf8Error errors from regexes #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not change any public API but only adds a new error variant, which an [API diff](https://github.com/Enselic/cargo-public-items) between `origin/master` and this PR shows: ``` % cargo public-items --diff-git-checkouts origin/master Propagate-FromUtf8Err Removed from the public API: ============================ (nothing) Changes to the public API: ========================== (nothing) Added to the public API: ======================== +pub enum variant syntect::parsing::ParseSyntaxError::FromUtf8Error(FromUtf8Error) +pub fn syntect::parsing::ParseSyntaxError::from(source: FromUtf8Error) -> Self ```
|
On a second thought, this can be made as part of a minor release later, if at all. Let's not spend time on this right now. I have another and maybe even final PR for #98 in the works, but it might take a while before I find the time to get it ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change any public API but only adds a new error variant, which an API diff between
origin/masterand this PR (Propagate-FromUtf8Err) shows:This is one step towards solving #98