Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock bitflags at ~1.2 to keep MSRV at 1.42 #348

Merged
merged 1 commit into from Aug 20, 2021
Merged

Lock bitflags at ~1.2 to keep MSRV at 1.42 #348

merged 1 commit into from Aug 20, 2021

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Aug 19, 2021

Timeline:

  • 9 days ago: The MSRV CI job in my PR was green
  • 7 days ago: bitflags 1.3.0 was released, which included this commit which bumps MSRV of bitflags to 1.46
  • 0 days ago: Merged MSRV CI job failed on master due to building with latest bitflags

Solution: Lock bitflags to be compatible with our current MSRV of 1.42.

@Enselic Enselic mentioned this pull request Aug 19, 2021
Merged
@trishume trishume merged commit c576530 into trishume:master Aug 20, 2021
@Enselic Enselic deleted the lock-bitflags-at-1.2 branch August 20, 2021 06:08
This was referenced Sep 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-hall keith-hall keith-hall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enselic @keith-hall @trishume