Remove parameterization on trino-opa tests #20556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have not reviewed but imho you dont need to have all these separate commits. Wait for confirmation from @dain before squashing though |
dain
reviewed
Feb 8, 2024
| 200); | ||
| public static final MockResponse UNDEFINED_RESPONSE = new MockResponse("{}", 404); | ||
| public static final MockResponse BAD_REQUEST_RESPONSE = new MockResponse("{}", 400); | ||
| 200); public static final MockResponse UNDEFINED_RESPONSE = new MockResponse("{}", 404); public static final MockResponse BAD_REQUEST_RESPONSE = new MockResponse("{}", 400); |
vagaerg
force-pushed
the
add-open-policy-agent-remove-parameterization
branch
from
83e119f
to
0bdc294
Compare
|
I rebased and squashed all commits. The other commit is addressing the comment @dain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #19532
@dain suggested removing parameterization #19532 (comment) , and as per #19532 (comment) we only removed parameterization from some tests.
This PR removes all parameterized tests
Additional context and related issues
N/A this change only affects tests
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: