Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require JDK 21 to run Trino #20010

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Require JDK 21 to run Trino #20010

merged 1 commit into from
Jan 8, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Dec 4, 2023

Release notes needed:

Require JDK 21.0.1 to run Trino

Closes #17017

@cla-bot cla-bot bot added the cla-signed label Dec 4, 2023
@github-actions github-actions bot added the docs label Dec 4, 2023
@wendigo wendigo force-pushed the serafin/jdk-21-requirement branch 3 times, most recently from 1602af5 to 15bca03 Compare December 4, 2023 12:30
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content changes look good. Need confirmation that the jvm.config should stay as is in the docs and other resources.

And then we need the confidence to merge this in as a hard requirement. I have not heard anything about problems with the docker container or in general about 21 at this stage.

@wendigo
Copy link
Contributor Author

wendigo commented Dec 5, 2023

Waiting for your command @martint @electrum @dain

@mosabua
Copy link
Member

mosabua commented Dec 8, 2023

Just fyi .. for Trino Summit keynote next Wednesday we are going to announce this as merged or as pending and request more feedback. Either is fine .. just @martint and myself need to know so we can adjust slide deck accordingly

@wendigo
Copy link
Contributor Author

wendigo commented Dec 9, 2023

@mosabua do we plan to make a release next week?

@mosabua
Copy link
Member

mosabua commented Dec 9, 2023

@mosabua do we plan to make a release next week?

Probably yes .. there are a bunch of things that need to be fixed from what I understand from @martint .. and I am not sure if we should merge this PR or wait another release or two for feedback. The summit would be a good way to announce a last time that we are looking for input.

@wendigo
Copy link
Contributor Author

wendigo commented Dec 10, 2023

@mosabua i'd want to merge this in a new year so let's ask for feedback

@wendigo
Copy link
Contributor Author

wendigo commented Dec 10, 2023

So basically in 2-3 releases from now

Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not heard anything further from any community members that would block this upgrade. I think we should go ahead.

@wendigo wendigo merged commit 09ef5b5 into master Jan 8, 2024
100 checks passed
@wendigo wendigo deleted the serafin/jdk-21-requirement branch January 8, 2024 21:39
@github-actions github-actions bot added this to the 436 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[JDK 21] Build and run Trino on JDK 21
4 participants