Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define additional repos only in submodules using them #11119

Merged
merged 1 commit into from Feb 23, 2022

Conversation

nineinchnick
Copy link
Member

Description

By moving rarely used custom repositories to modules where they're actually used, this is supposed to avoid hitting them for every artifact.

Custom repositories are checked before central, defined in the Super POM, as described here: https://maven.apache.org/guides/mini/guide-multiple-repositories.html#repository-order

Is this change a fix, improvement, new feature, refactoring, or other?
Refactoring - doesn't change any functionality, might speed up jobs in the CI where the local repository is always empty.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
Only pom.xml.

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the duplication isn't bad enough to worry about IMO.
This should help builds with empty repos (CI/clean local runs).

Might want to add some context from the PR description to commit message too though.

Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submoules -> submodules

By moving rarely used custom repositories to modules
where they're actually used, this is supposed to avoid hitting them
for every artifact.
@nineinchnick nineinchnick changed the title Define additional repos only in submoules using them Define additional repos only in submodules using them Feb 21, 2022
@nineinchnick
Copy link
Member Author

trino-hive failure looks like a flake, it passed in the previous run and I only reworded the commit message now (without a rebase).
This failed:

2022-02-21T20:02:25.5986974Z 2022-02-21T14:02:24.485-0600	ERROR	pool-3-thread-2	io.trino.testng.services.ProgressLoggingListener	[TEST FAILURE] io.trino.plugin.hive.TestHive3OnDataLake.testInsertOverwritePartitionedAndBucketedExternalTable; (took: 25.5 seconds)
2022-02-21T20:02:25.6031582Z java.io.UncheckedIOException: java.net.SocketTimeoutException: Read timed out

But there's also a bunch of:

2022-02-21T20:02:25.7868983Z 2022-02-21T14:02:25.068-0600	INFO	Service Thread	io.airlift.stats.JmxGcMonitor	Major GC: application 103820ms, stopped 9909ms: 3.43GB -> 2.38GB

so maybe we could somehow tune the configs to fit the runners or there's a leak in tests. Should I investigate further?

@findepi
Copy link
Member

findepi commented Feb 23, 2022

so maybe we could somehow tune the configs to fit the runners or there's a leak in tests. Should I investigate further?

apache/maven-surefire#407 might be related.

@findepi findepi merged commit 08b881a into trinodb:master Feb 23, 2022
@github-actions github-actions bot added this to the 372 milestone Feb 23, 2022
@nineinchnick nineinchnick deleted the custom-repos-in-submodules branch November 2, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants