Skip to content

Commit

Permalink
build: remove dependency on @angular/elements and custom elements pol…
Browse files Browse the repository at this point in the history
…yfill

We weren't using `@angular/elements` for anything and the `custom-elements` polyfill was only included because of it.
  • Loading branch information
trik committed Jun 8, 2021
1 parent 7fb2f7a commit 8791f45
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 33 deletions.
1 change: 0 additions & 1 deletion package.json
Expand Up @@ -55,7 +55,6 @@
"@angular/common": "^12.0.0-rc.0",
"@angular/compiler": "^12.0.0-rc.0",
"@angular/core": "^12.0.0-rc.0",
"@angular/elements": "^12.0.0-rc.0",
"@angular/forms": "^12.0.0-rc.0",
"@angular/material": "^12.0.0-rc.0",
"@angular/platform-browser": "^12.0.0-rc.0",
Expand Down
1 change: 0 additions & 1 deletion packages.bzl
Expand Up @@ -64,7 +64,6 @@ ANGULAR_NGCC_BUNDLES = [
("@angular/common", ["common-http-testing.umd.js", "common-http.umd.js", "common-testing.umd.js", "common.umd.js"]),
("@angular/compiler", ["compiler-testing.umd.js"]),
("@angular/core", ["core-testing.umd.js", "core.umd.js"]),
("@angular/elements", ["elements.umd.js"]),
("@angular/forms", ["forms.umd.js"]),
("@angular/material", ["material-autocomplete.umd.js", "material-button.umd.js", "material-button-toggle.umd.js", "material-card.umd.js", "material-checkbox.umd.js", "material-chips.umd.js", "material-core.umd.js", "material-dialog.umd.js", "material-divider.umd.js", "material-expansion.umd.js", "material-form-field.umd.js", "material-grid-list.umd.js", "material-icon.umd.js", "material-input.umd.js", "material-list.umd.js", "material-menu.umd.js", "material-radio.umd.js", "material-select.umd.js", "material-sidenav.umd.js", "material-slide-toggle.umd.js", "material-slider.umd.js", "material-table.umd.js", "material-tabs.umd.js", "material-toolbar.umd.js", "material-tooltip.umd.js"]),
("@angular/platform-browser-dynamic", ["platform-browser-dynamic-testing.umd.js", "platform-browser-dynamic.umd.js"]),
Expand Down
1 change: 0 additions & 1 deletion src/dev-app/BUILD.bazel
Expand Up @@ -72,7 +72,6 @@ filegroup(
"@npm//:node_modules/@ajf/icons/fonts/ajf.woff",
"@npm//:node_modules/@angular/material/prebuilt-themes/indigo-pink.css",
"@npm//:node_modules/@ionic/angular/css/ionic.bundle.css",
"@npm//:node_modules/@webcomponents/custom-elements/custom-elements.min.js",
"@npm//:node_modules/core-js-bundle/index.js",
"@npm//:node_modules/flag-icon-css/css/flag-icon.min.css",
"@npm//:node_modules/flag-icon-css/flags/4x3/bf.svg",
Expand Down
1 change: 0 additions & 1 deletion src/dev-app/example/BUILD.bazel
Expand Up @@ -9,7 +9,6 @@ ng_module(
"//src/ajf-examples",
"//src/ajf-examples/private",
"@npm//@angular/cdk",
"@npm//@angular/elements",
"@npm//@angular/material",
],
)
8 changes: 1 addition & 7 deletions src/dev-app/index.html
Expand Up @@ -15,13 +15,7 @@
<link href="flag-icon-css/css/flag-icon.min.css" rel="stylesheet">
<link href="leaflet/dist/leaflet.css" rel="stylesheet">

<script>
if (window.customElements) {
window.customElements.forcePolyfill = true;
}
</script>
<script src="@webcomponents/custom-elements/custom-elements.min.js"></script>

<!-- FontAwesome for mat-icon demo. -->
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css">
</head>
<body>
Expand Down
2 changes: 0 additions & 2 deletions src/e2e-app/BUILD.bazel
Expand Up @@ -34,7 +34,6 @@ ng_module(
"//src/material/reports",
"@npm//@angular/common",
"@npm//@angular/core",
"@npm//@angular/elements",
"@npm//@angular/forms",
"@npm//@angular/platform-browser",
"@npm//@angular/router",
Expand Down Expand Up @@ -73,7 +72,6 @@ concatjs_devserver(
"@npm//numbro",
"@npm//pdfmake",
"@npm//@ngx-translate/core",
"@npm//@webcomponents/custom-elements",
":index.html",
],
tags = ["manual"],
Expand Down
8 changes: 0 additions & 8 deletions src/e2e-app/index.html
Expand Up @@ -15,14 +15,6 @@

<!-- FontAwesome for mat-icon demo. -->
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css">

<!-- Angular Elements setup. -->
<script>
if (window.customElements) {
window.customElements.forcePolyfill = true;
}
</script>
<script src="@webcomponents/custom-elements/custom-elements.min.js"></script>
</head>
<body>
<e2e-app>Loading...</e2e-app>
Expand Down
12 changes: 0 additions & 12 deletions yarn.lock
Expand Up @@ -163,13 +163,6 @@
yaml "^1.10.0"
yargs "^16.2.0"

"@angular/elements@^12.0.0-rc.0":
version "12.0.0-rc.0"
resolved "https://registry.yarnpkg.com/@angular/elements/-/elements-12.0.0-rc.0.tgz#c01e3a00a121e6312240e82164cd941f08d0823e"
integrity sha512-WIwMxNesgpXp12kpfsgz++7oadJ4aQhxFzreqhUnGHGCS0GECbJU8EGSuqyO4TMRP5FZJRDgETRUqysa/wNfgQ==
dependencies:
tslib "^2.1.0"

"@angular/forms@^12.0.0-rc.0":
version "12.0.0-rc.0"
resolved "https://registry.yarnpkg.com/@angular/forms/-/forms-12.0.0-rc.0.tgz#1a1f71be85f8ad4e41a4ef9fe5dbef3bb04a5420"
Expand Down Expand Up @@ -1464,11 +1457,6 @@
"@typescript-eslint/types" "4.14.0"
eslint-visitor-keys "^2.0.0"

"@webcomponents/custom-elements@^1.1.0":
version "1.4.3"
resolved "https://registry.yarnpkg.com/@webcomponents/custom-elements/-/custom-elements-1.4.3.tgz#1800d49f38bb4425ebfd160b50115e62776109d7"
integrity sha512-iD0YW46SreUQANGccywK/eC+gZELNHocZZrY2fGwrIlx/biQOTkAF9IohisibHbrmIHmA9pVCIdGwzfO+W0gig==

"@zxing/library@^0.17.0":
version "0.17.1"
resolved "https://registry.yarnpkg.com/@zxing/library/-/library-0.17.1.tgz#4c82bf401391c2b79bfbab0a6b1143da6d8feb1a"
Expand Down

0 comments on commit 8791f45

Please sign in to comment.