Remove direct dgrijalva/jwt-go dependency #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzununbekov
approved these changes
Oct 6, 2021
antoineco
reviewed
Oct 6, 2021
go.mod
Outdated
| github.com/Azure/go-autorest/autorest v0.11.20 | ||
| github.com/Azure/go-autorest/autorest/adal v0.9.13 | ||
| github.com/Azure/go-autorest/autorest v0.11.21 | ||
| github.com/Azure/go-autorest/autorest/adal v0.9.16 |
There was a problem hiding this comment.
Are those unrelated version bumps needed?
Can we push them separately?
There was a problem hiding this comment.
no, they are not needed.
I wanted to also remove transitive dependencies to clean go.sum, but it is tougher than expected.
I'll remove them
There was a problem hiding this comment.
the rabbit hole is here at the moment
antoineco
approved these changes
Oct 6, 2021
odacremolbap
changed the title
odacremolbap
force-pushed
the
fix/replace-jwt-library
branch
from
5d8aa9e
to
12ce3b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dgrijalva/jwt-godepencendy.Closes #104
There are still indirect dependencies that might need some more effort to remove.
https://github.com/knative/pkg/blob/a00ba487121ef45e7f14f1d59187ea6bb498bb4e/go.sum#L136