Add middle-word-em extra
#522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extra will control whether emphasis in the middle of words will be allowed. When disabled, a whitespace will be requitred on both sides of the emphasis to be considered. The default is to allow middle word emphasis
|
Score LGTM thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #38 by adding an extra to disable emphasis syntax when in the middle of a word.
The current behaviour of the library is to always convert
this_text_heretothis<em>text</em>here. However, this is not always desirable, as highlighted in #38.The new
middle-word-emextra will allow users to allow (default) or disallow this behaviour by passingextras={'middle-word-em': True/False}. When disabled, any emphasis will be required to have a word boundary (r'\b') surrounding it.For backwards compatibility, I've kept the default behaviour as allowing middle word emphasis. Users must explicitly disable it. Passing
extras=['middle-word-em']will not work.