Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept [X] as marked task #328

Merged
merged 2 commits into from May 28, 2019
Merged

Accept [X] as marked task #328

merged 2 commits into from May 28, 2019

Commits on May 25, 2019

  1. Accept [X] as marked task 

    I'm a developer at @CCExtractor and we will be using this project to send markdown to html emails in our CI system.

### The Issue
Github supports using either `[x]` or `[X]` in marking task list item. Unfortunately, markdown2 only converts `[x]` to checked list.

### The Fix
I've changed the regex to accept [X] in the tasklist marked regex subgroup and consequently, we check using a conditional block.
    @thealphadollar
    thealphadollar committed May 25, 2019
    Copy the full SHA
    80255ce View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. add tests for updated task_list

    @thealphadollar
    thealphadollar committed May 28, 2019
    Copy the full SHA
    af70b30 View commit details
    Browse the repository at this point in the history