Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't auto link patterns surrounded by """. #322

Merged
merged 2 commits into from Mar 5, 2019
Merged

Don't auto link patterns surrounded by """. #322

merged 2 commits into from Mar 5, 2019

Commits on Jan 24, 2019

  1. Don't auto link patterns surrounded by """. 

    This allows the prevention of `[WikiWikiWeb](http://wiki.c2.com/?WikiWikiWeb)`
being transformed to `<a href="http://wiki.c2.com/?&lt;a href=&quot;aw.cgi?page=WikiWikiWeb&quot;&gt;WikiWikiWeb&lt;/a&gt;">WikiWikiWeb</a>` when
the pattern linker sees the second WikiCase word by surrounding it with triple quotes: so `[WikiWikiWeb](http://wiki.c2.com/?"""WikiWikiWeb""")`
is now transformed to `<a href="http://wiki.c2.com/?WikiWikiWeb">WikiWikiWeb</a>`.

The function responsible, _do_link_patterns(), already checked for the cases that the pattern was inside square brackets, or
was preceeded by `](` or suffixed by `")`, and skips expanding in these cases. This addition simply adds a check that the pattern is not surrounded
by triple quotes; the triple quotes are stripped from the output.
    @aelzenaar
    aelzenaar committed Jan 24, 2019
    Copy the full SHA
    7b259b9 View commit details
    Browse the repository at this point in the history

  2. Add tests for triple quotes feature (from 7b259b9)

    @aelzenaar
    aelzenaar committed Jan 24, 2019
    Copy the full SHA
    0660157 View commit details
    Browse the repository at this point in the history