Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept [X] as marked task #328

Merged
merged 2 commits into from May 28, 2019
Merged

Accept [X] as marked task #328

merged 2 commits into from May 28, 2019

Conversation

thealphadollar
Copy link
Contributor

@thealphadollar thealphadollar commented May 25, 2019

I'm a developer at @CCExtractor and we will be using this project to send markdown to html emails in our CI system.

The Issue

Github supports using either [x] or [X] in marking task list item. Unfortunately, markdown2 only converts [x] to checked list.

e.g.

  • this is marked
  • this is also marked
  • this is not marked

The Fix

I've changed the regex to accept [X] in the tasklist marked regex subgroup and consequently, we check using a conditional block.

I'm a developer at @CCExtractor and we will be using this project to send markdown to html emails in our CI system.

### The Issue
Github supports using either `[x]` or `[X]` in marking task list item. Unfortunately, markdown2 only converts `[x]` to checked list.

### The Fix
I've changed the regex to accept [X] in the tasklist marked regex subgroup and consequently, we check using a conditional block.
@nicholasserra
Copy link
Collaborator

Looks good to me, thanks! Can you modify the task list test to also use the uppercase X?

@thealphadollar
Copy link
Contributor Author

@nicholasserra Done.

Please merge this ASAP so that we can update our version.

@nicholasserra nicholasserra merged commit f3259c6 into trentm:master May 28, 2019
@thealphadollar
Copy link
Contributor Author

@nicholasserra How much time would it take for the PyPI hosted package to update from here?

I would like to update our server installed markdown-2 with the latest changes.

@nicholasserra
Copy link
Collaborator

I'll try to get an update out within the next couple days

@thealphadollar
Copy link
Contributor Author

Thanks a lot. I would highly appreciate if you can give me an update (preferably in this thread or somewhere I can subscribe) once you've done the PyPI deployment.

@nicholasserra
Copy link
Collaborator

2.3.8 has been released to pypi

@thealphadollar
Copy link
Contributor Author

thealphadollar commented May 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants