Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a developer at @CCExtractor and we will be using this project to send markdown to html emails in our CI system.
The Issue
Github supports using either
[x]
or[X]
in marking task list item. Unfortunately, markdown2 only converts[x]
to checked list.e.g.
The Fix
I've changed the regex to accept [X] in the tasklist marked regex subgroup and consequently, we check using a conditional block.