Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade serial test again and ignore all versions of this lib #1785

Closed
wants to merge 2 commits into from

Conversation

mfelsche
Copy link
Member

Pull request

Description

Now with infinite ignoring power for serial_test

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

snot

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
@Licenser
Copy link
Member

Do we really want to fully ignore it, I opened a ticket upstream with the issue palfrey/serial_test#68

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1785 (12aaa4d) into main (269ab9e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1785      +/-   ##
==========================================
- Coverage   89.69%   89.69%   -0.01%     
==========================================
  Files         236      236              
  Lines       48220    48220              
==========================================
- Hits        43253    43251       -2     
- Misses       4967     4969       +2     
Flag Coverage Δ
clicommand 12.24% <ø> (ø)
cliintegration 53.10% <ø> (-0.19%) ⬇️
cliunit 12.62% <ø> (ø)
unittests 86.84% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/utils/metrics.rs 92.39% <0.00%> (-2.18%) ⬇️
src/connectors/utils/reconnect.rs 95.02% <0.00%> (-0.83%) ⬇️
src/connectors/impls/kafka/producer.rs 75.00% <0.00%> (-0.72%) ⬇️
src/connectors/impls/gpubsub/consumer.rs 91.84% <0.00%> (-0.43%) ⬇️
src/connectors.rs 87.20% <0.00%> (ø)
src/connectors/source.rs 88.33% <0.00%> (+0.34%) ⬆️
src/pipeline.rs 86.24% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269ab9e...12aaa4d. Read the comment docs.

@mfelsche
Copy link
Member Author

We found a solution.

@mfelsche mfelsche closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants