Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce randomized testing for queries, fix the revealed bugs #1496

Merged
merged 4 commits into from Nov 21, 2021
Merged

Introduce randomized testing for queries, fix the revealed bugs #1496

merged 4 commits into from Nov 21, 2021

Commits on Nov 21, 2021

  1. Add a randomized test for query matching

    @maxbrunsfeld
    maxbrunsfeld committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    f69c486 View commit details
    Browse the repository at this point in the history

  2. Rename Query::step_is_definite -> is_pattern_guaranteed_at_step

    @maxbrunsfeld
    maxbrunsfeld committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    142f4b6 View commit details
    Browse the repository at this point in the history

  3. Improve query execution logging

    @maxbrunsfeld
    maxbrunsfeld committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    fea3eca View commit details
    Browse the repository at this point in the history

  4. Fix query bugs revealed by randomized tests 

    * Fix bugs related to named wildcard patterns vs regular wildcard patterns.
* Fix handling of extra nodes during query analysis. Previously, the
expected child_index was updated incorrectly after an extra node,
leading to false "impossible pattern" errors.
* Refine logic for avoiding unnecessary state-splitting due to fallible steps.
Compute *two* different analysis results related to step fallibility:
  * `root_pattern_guaranteed` which, like before, summarizes whether the
    entire pattern is guaranteed to match once this step is reached.
  * `parent_pattern_guaranteed` - which just indicates whether the
    immediate parent pattern is guaranteed. This is now used when
    deciding whether it's necessary to split a match state.
    @maxbrunsfeld
    maxbrunsfeld committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    26dac9b View commit details
    Browse the repository at this point in the history