Remove special-cased parsing for built-in attributes #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse all attribute using the general attribute syntax
clason
added a commit
to nvim-treesitter/nvim-treesitter
that referenced
this pull request
Nov 5, 2022
* `if_let_expression` was removed in tree-sitter/tree-sitter-rust#152 * `attributes` were reworked in tree-sitter/tree-sitter-rust#163 (no more `meta-item`)
clason
added a commit
to nvim-treesitter/nvim-treesitter
that referenced
this pull request
Nov 5, 2022
* `if_let_expression` was removed in tree-sitter/tree-sitter-rust#152 * `attributes` were reworked in tree-sitter/tree-sitter-rust#163 (no more `meta-item`)
mars90226
added a commit
to mars90226/dotvim
that referenced
this pull request
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #93. Apologies for not weighing in on the initial discussion of that PR.
I believe pretty strongly that special handling of specific language builtins shouldn't be implemented in the parser itself. Over time, that approach will bloat the binary size of the parser, thereby making it less useful to most consumers. It will also make the parser more tightly-coupled to small changes to the language, like adding new built-in attributes.
I think the right approach was option 3. proposed in the PR body by @ninevra (which @resolritter also argued for). In this PR, I've adopted that approach.
Let me know if anyone has concerns about this, and sorry for the churn.