Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Ruby 3.2 #139

Merged
merged 3 commits into from Mar 14, 2023
Merged

CI: Add Ruby 3.2 #139

merged 3 commits into from Mar 14, 2023

Conversation

ashie
Copy link
Collaborator

@ashie ashie commented Jan 17, 2023

Signed-off-by: Takuro Ashie ashie@clear-code.com

@daipom
Copy link
Contributor

daipom commented Mar 6, 2023

I also ran into the same problem.
This is caused by the old rake version.
We need this fix for rake.

This means we need to update rake and rspec.

@ashie
Copy link
Collaborator Author

ashie commented Mar 14, 2023

I tried it once but not yet completed, some tests stall on latest RSpec.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie
Copy link
Collaborator Author

ashie commented Mar 14, 2023

Oh? Now I've tested them locally and succeeded without any problems.
Fixed by upstream?

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
In our cases we should use later one as of RSpec 3:
https://rubydoc.info/gems/rspec-core/RSpec/Core/Pending

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie
Copy link
Collaborator Author

ashie commented Mar 14, 2023

CI succeeded on all environments.

@ashie ashie merged commit c523d55 into master Mar 14, 2023
8 checks passed
@ashie ashie deleted the ci-ruby-3.2 branch March 14, 2023 03:47
@daipom
Copy link
Contributor

daipom commented Mar 14, 2023

Yay! Thanks!

@ashie ashie mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants