Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.15 #64

Merged
merged 2 commits into from Feb 10, 2020
Merged

Release 0.5.15 #64

merged 2 commits into from Feb 10, 2020

Conversation

hieudion
Copy link
Contributor

@hieudion hieudion commented Feb 3, 2020

Release 0.5.15
specify version 1.2.5 to tzinfo to avoid changes in 1.2.6 causes fail in UT.
More information:
https://travis-ci.org/treasure-data/embulk-input-mixpanel/jobs/638469421

/home/travis/build/treasure-data/embulk-input-mixpanel/test/test_range_generator.rb:40:in `test_1_fetch_day'
/home/travis/build/treasure-data/embulk-input-mixpanel/lib/range_generator.rb:14:in `generate_range'
/home/travis/build/treasure-data/embulk-input-mixpanel/lib/range_generator.rb:38:in `show_warnings'
/home/travis/build/treasure-data/embulk-input-mixpanel/lib/range_generator.rb:72:in `from_date_too_early?'
/home/travis/build/treasure-data/embulk-input-mixpanel/lib/range_generator.rb:76:in `today'
/home/travis/.rvm/gems/jruby-9.0.5.0/gems/activesupport-5.2.4.1/lib/active_support/values/time_zone.rb:234:in `[]'
/home/travis/.rvm/gems/jruby-9.0.5.0/gems/activesupport-5.2.4.1/lib/active_support/values/time_zone.rb:300:in `initialize'
/home/travis/.rvm/gems/jruby-9.0.5.0/gems/activesupport-5.2.4.1/lib/active_support/values/time_zone.rb:206:in `find_tzinfo'
/home/travis/.rvm/gems/jruby-9.0.5.0/gems/tzinfo-1.2.6/lib/tzinfo/timezone.rb:113:in `new'
/home/travis/.rvm/gems/jruby-9.0.5.0/gems/tzinfo-1.2.6/lib/tzinfo/timezone.rb:92:in `get'
/home/travis/.rvm/gems/jruby-9.0.5.0/gems/tzinfo-1.2.6/lib/tzinfo/zoneinfo_data_source.rb:211:in `load_timezone_info'
/home/travis/.rvm/gems/jruby-9.0.5.0/gems/tzinfo-1.2.6/lib/tzinfo/zoneinfo_timezone_info.rb:29:in `initialize'
Error: test_1_fetch_day(RangeGeneratorTest::GenerateRangeTest): ArgumentError: wrong number of arguments (0 for 1)

The syntax failure could be the jruby issue, issue itself I filed in tzinfo: tzinfo/tzinfo#114

Copy link
Contributor

@trung-huynh trung-huynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hieudion hieudion merged commit 802b991 into master Feb 10, 2020
@hieudion hieudion deleted the release-v0.5.15 branch February 10, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants