Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix %Y date format %Y #379

Merged

Conversation

joshuacronemeyer
Copy link
Collaborator

Potential fix for #377

@augustoccesar
Copy link

Since you mentioned the place where formats are listed as todo:

#TODO Support these formats
# '%G %V %w',
# '%G %V %u',
# '%C %g %V %w',
# '%C %g %V %u',
# '%Y %U %w',
# '%Y %U %u',
# '%Y %W %w',
# '%Y %W %u',
# '%C %y %U %w',
# '%C %y %U %u',
# '%C %y %W %w',
# '%C %y %W %u',

Do you think it would have value to add the format %Y to the supported list?

Other than that LGMT! 👍

@joshuacronemeyer
Copy link
Collaborator Author

Since you mentioned the place where formats are listed as todo:

#TODO Support these formats
# '%G %V %w',
# '%G %V %u',
# '%C %g %V %w',
# '%C %g %V %u',
# '%Y %U %w',
# '%Y %U %u',
# '%Y %W %w',
# '%Y %W %u',
# '%C %y %U %w',
# '%C %y %U %u',
# '%C %y %W %w',
# '%C %y %W %u',

Do you think it would have value to add the format %Y to the supported list?
Other than that LGMT! 👍

Thanks for looking. I actually realized that test will only work for date formats that are fully specified dates. It's converting from a specific date to a string and back to the date, but in the case of this date format where it's just the Year that doesn't work.

@joshuacronemeyer joshuacronemeyer merged commit 138bc93 into travisjeffery:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date.strptime returns wrong month for %Y
2 participants