[pull] dev from testcontainers:dev #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Fix invalid workflow file and bump version to 0.9.1
Fixes #319. Co-authored-by: Josh Hershberg <yehoshua@redis.com>
`bollard-stubs` is a crate with autogenerated models for the Docker API. Previously, we were using models embedded in `bollard` inside CLI, while the client itself wasn't required. Now we're making `bollard` an optional dependency and including it only when we need the heavy-lifting, i.e. the client logic. The internal implementation of the CLI client uses the models from `bollard-stubs` from now on.
323: Replace all Shiplift usages with Bollard r=thomaseizinger a=andrey-yantsen Judging by the low activity in [shiplift](https://github.com/softprops/shiplift) (last commit on 1 Sep 2021, quite a few unmerged PRs after September and lack of response in the maintenance status clarification request softprops/shiplift#321), I think it's a good time to switch to a more actively maintained crate. I picked Ballard because of the more active repo than `docker-api-rs`. And I liked the idea with the code generation from the API :) Co-authored-by: Andrey Yantsen <andrey@janzen.su>
This crate is used only inside the Http client, there's no reason to include it for everybody.
cargo officially allows key `rust-version` starting from Rust 1.56.0. In the older versions, the key will be ignored (though a warning will be displayed). Having this value defined in Cargo.toml provides better visibility within the ecosystem. And it's just nicer to have this value specified in the config and not in a Github Workflow, even if reading it inside the workflow is a bit clunky :)
328: Add MSRV to Cargo.toml r=thomaseizinger a=andrey-yantsen cargo officially allows key `rust-version` starting from Rust 1.56.0. In the older versions, the key will be ignored (though a warning will be displayed). Having this value defined in Cargo.toml provides better visibility within the ecosystem. And it's just nicer to have this value specified in the config and not in a Github Workflow, even if reading it inside the workflow is a bit clunky :) Co-authored-by: Andrey Yantsen <andrey@janzen.su>
329: Add #[must_use] for RunnableImage and GenericImage r=thomaseizinger a=andrey-yantsen This PR fixes the errors reported by the nightly cargo: https://github.com/testcontainers/testcontainers-rs/runs/4847806082?check_suite_focus=true. More info about the lint can be found here: https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use. Co-authored-by: Andrey Yantsen <andrey@janzen.su>
330: Add missed args passthrough in the HTTP client r=thomaseizinger a=andrey-yantsen Initially, I was trying to test if #271 was fixed after migrating to Bollard (and yes, it was!). I thought that the simplest way to test it is just run something like `docker run --rm ubuntu:latest bash -c 'sleep 10 && echo ready && sleep 10'`. It worked like a charm for the Cli client but started to fail as soon as I switched to the HTTP one. Long story short — #270 will be fixed with the changes in this PR, and #271 can already be closed. You seem to just forget about the args when you were implementing the HTTP client :) Fixes #270. Co-authored-by: Andrey Yantsen <andrey@janzen.su>
327: Add WaitFor::Healthcheck r=thomaseizinger a=andrey-yantsen In this PR, I added the most naive and simple implementation for the `WaitFor::Healthcheck`. The ideal option will be to remove `delay` from the Enum. Still, the current implementation gives some flexibility to the users and eliminates the need of hardcoding the delay inside the crate. As always, I'm open to suggestions :) Fixes #321. Co-authored-by: Andrey Yantsen <andrey@janzen.su>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
340: Bump actions/checkout from 2 to 3 r=thomaseizinger a=dependabot[bot] Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <ul> <li>Update default runtime to node16</li> </ul> <h2>v2.4.0</h2> <ul> <li>Convert SSH URLs like <code>org-<ORG_ID>`@github.com:</code>` to <code>https://github.com/</code> - <a href="https://github-redirect.dependabot.com/actions/checkout/pull/621">pr</a></li> </ul> <h2>v2.3.5</h2> <p>Update dependencies</p> <h2>v2.3.4</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/379">Add missing <code>await</code>s</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/360">Swap to Environment Files</a></li> </ul> <h2>v2.3.3</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/345">Remove Unneeded commit information from build logs</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/326">Add Licensed to verify third party dependencies</a></li> </ul> <h2>v2.3.2</h2> <p><a href="https://github-redirect.dependabot.com/actions/checkout/pull/320">Add Third Party License Information to Dist Files</a></p> <h2>v2.3.1</h2> <p><a href="https://github-redirect.dependabot.com/actions/checkout/pull/284">Fix default branch resolution for .wiki and when using SSH</a></p> <h2>v2.3.0</h2> <p><a href="https://github-redirect.dependabot.com/actions/checkout/pull/278">Fallback to the default branch</a></p> <h2>v2.2.0</h2> <p><a href="https://github-redirect.dependabot.com/actions/checkout/pull/258">Fetch all history for all tags and branches when fetch-depth=0</a></p> <h2>v2.1.1</h2> <p>Changes to support GHES (<a href="https://github-redirect.dependabot.com/actions/checkout/pull/236">here</a> and <a href="https://github-redirect.dependabot.com/actions/checkout/pull/248">here</a>)</p> <h2>v2.1.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/191">Group output</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/199">Changes to support GHES alpha release</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/184">Persist core.sshCommand for submodules</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/163">Add support ssh</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/179">Convert submodule SSH URL to HTTPS, when not using SSH</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/157">Add submodule support</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/144">Follow proxy settings</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/141">Fix ref for pr closed event when a pr is merged</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/128">Fix issue checking detached when git less than 2.22</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>v2.3.1</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/284">Fix default branch resolution for .wiki and when using SSH</a></li> </ul> <h2>v2.3.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/278">Fallback to the default branch</a></li> </ul> <h2>v2.2.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/258">Fetch all history for all tags and branches when fetch-depth=0</a></li> </ul> <h2>v2.1.1</h2> <ul> <li>Changes to support GHES (<a href="https://github-redirect.dependabot.com/actions/checkout/pull/236">here</a> and <a href="https://github-redirect.dependabot.com/actions/checkout/pull/248">here</a>)</li> </ul> <h2>v2.1.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/191">Group output</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/199">Changes to support GHES alpha release</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/184">Persist core.sshCommand for submodules</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/163">Add support ssh</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/179">Convert submodule SSH URL to HTTPS, when not using SSH</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/157">Add submodule support</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/144">Follow proxy settings</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/141">Fix ref for pr closed event when a pr is merged</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/128">Fix issue checking detached when git less than 2.22</a></li> </ul> <h2>v2.0.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/108">Do not pass cred on command line</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/107">Add input persist-credentials</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/104">Fallback to REST API to download repo</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/checkout/commit/a12a3943b4bdde767164f792f33f40b04645d846"><code>a12a394</code></a> update readme for v3 (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/708">#708</a>)</li> <li><a href="https://github.com/actions/checkout/commit/8f9e05e482293f862823fcca12d9eddfb3723131"><code>8f9e05e</code></a> Update to node 16 (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/689">#689</a>)</li> <li><a href="https://github.com/actions/checkout/commit/230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7"><code>230611d</code></a> Change secret name for PAT to not start with GITHUB_ (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/623">#623</a>)</li> <li>See full diff in <a href="https://github.com/actions/checkout/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Reclaim zombie docker inspect command process * Panic on unhealthy
Co-authored-by: Artem Medvedev <artem.medvedev@workato.com>
Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) from 2.7.0 to 2.7.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md">Swatinem/rust-cache's changelog</a>.</em></p> <blockquote> <h2>2.7.1</h2> <ul> <li>Update toml parser to fix parsing errors.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/Swatinem/rust-cache/commit/3cf7f8cc28d1b4e7d01e3783be10a97d55d483c8"><code>3cf7f8c</code></a> 2.7.1</li> <li><a href="https://github.com/Swatinem/rust-cache/commit/e03705e0310d26258e217a66d720506bdda81e15"><code>e03705e</code></a> changelog</li> <li><a href="https://github.com/Swatinem/rust-cache/commit/b86d1c6caae0be249b32391fa5442415f7136f26"><code>b86d1c6</code></a> bump all the other dependencies too</li> <li><a href="https://github.com/Swatinem/rust-cache/commit/f27990c89aee0355fa52f81c482c48f82b74770c"><code>f27990c</code></a> Update Dependencies (<a href="https://redirect.github.com/swatinem/rust-cache/issues/172">#172</a>)</li> <li>See full diff in <a href="https://github.com/swatinem/rust-cache/compare/v2.7.0...v2.7.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
When switching from the Cli client to the Http client I noticed that the expose_ports of my Image were no longer dynamically mapping to free ports on the docker daemon's host. It seems like this is a gap to fill as a user might want a specific container port (that the image manifest may or may not have an EXPOSE layer for) mapped to a free port on the daemon host.
When spawning multiple docker containers in the same test, communication amongst them can be achieved over the docker default gateway. In DinD environments, such as when running jobs on a CI pipeline, the docker [`--add-host`](https://docs.docker.com/engine/reference/commandline/container_run/#option) can be employed to basically enter new entries in the `/etc/hosts` files. This allows to avoid binding all container ports to the host environment. The flag API counterpart is implemented on the `RunnableImage` struct instead of on the generic image since I reckon it makes more sense within this crate phylosophy, I hope !-). A test runs 2 containers: - an http_server - a `curl` client and the `curl` client completes when receiving `foo` from the server on the alias hostname. In case the hostname wasn't resolve it'd panic.
It also makes the CI green
Updates the requirements on [reqwest](https://github.com/seanmonstar/reqwest) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/seanmonstar/reqwest/releases">reqwest's releases</a>.</em></p> <blockquote> <h2>v0.12.3</h2> <h2>What's Changed</h2> <ul> <li>Add <code>FromStr</code> for <code>dns::Name</code>.</li> <li>Add <code>ClientBuilder::built_in_webpki_certs(bool)</code> to enable them separately.</li> <li>Add <code>ClientBuilder::built_in_native_certs(bool)</code> to enable them separately.</li> <li>Fix sending <code>content-length: 0</code> for GET requests.</li> <li>Fix response body <code>content_length()</code> to return value when timeout is configured.</li> <li>Fix <code>ClientBuilder::resolve()</code> to use lowercase domain names.</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/zuisong"><code>@zuisong</code></a> made their first contribution in <a href="https://redirect.github.com/seanmonstar/reqwest/pull/2207">seanmonstar/reqwest#2207</a></li> <li><a href="https://github.com/djc"><code>@djc</code></a> made their first contribution in <a href="https://redirect.github.com/seanmonstar/reqwest/pull/2222">seanmonstar/reqwest#2222</a></li> <li><a href="https://github.com/krant"><code>@krant</code></a> made their first contribution in <a href="https://redirect.github.com/seanmonstar/reqwest/pull/2226">seanmonstar/reqwest#2226</a></li> <li><a href="https://github.com/Kriskras99"><code>@Kriskras99</code></a> made their first contribution in <a href="https://redirect.github.com/seanmonstar/reqwest/pull/2236">seanmonstar/reqwest#2236</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/seanmonstar/reqwest/compare/v0.12.2...v0.12.3">https://github.com/seanmonstar/reqwest/compare/v0.12.2...v0.12.3</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md">reqwest's changelog</a>.</em></p> <blockquote> <h2>v0.12.3</h2> <ul> <li>Add <code>FromStr</code> for <code>dns::Name</code>.</li> <li>Add <code>ClientBuilder::built_in_webpki_certs(bool)</code> to enable them separately.</li> <li>Add <code>ClientBuilder::built_in_native_certs(bool)</code> to enable them separately.</li> <li>Fix sending <code>content-length: 0</code> for GET requests.</li> <li>Fix response body <code>content_length()</code> to return value when timeout is configured.</li> <li>Fix <code>ClientBuilder::resolve()</code> to use lowercase domain names.</li> </ul> <h2>v0.12.2</h2> <ul> <li>Fix missing ALPN when connecting to socks5 proxy with rustls.</li> <li>Fix TLS version limits with rustls.</li> <li>Fix not detected ALPN h2 from server with native-tls.</li> </ul> <h2>v0.12.1</h2> <ul> <li>Fix <code>ClientBuilder::interface()</code> when no TLS is enabled.</li> <li>Fix <code>TlsInfo::peer_certificate()</code> being truncated with rustls.</li> <li>Fix panic if <code>http2</code> feature disabled but TLS negotiated h2 in ALPN.</li> <li>Fix <code>Display</code> for <code>Error</code> to not include its source error.</li> </ul> <h1>v0.12.0</h1> <ul> <li>Upgrade to <code>hyper</code>, <code>http</code>, and <code>http-body</code> v1.</li> <li>Add better support for converting to and from <code>http::Request</code> and <code>http::Response</code>.</li> <li>Add <code>http2</code> optional cargo feature, default on.</li> <li>Add <code>charset</code> optional cargo feature, default on.</li> <li>Add <code>macos-system-configuration</code> cargo feature, default on.</li> <li>Change all optional dependencies to no longer be exposed as implicit features.</li> <li>Add <code>ClientBuilder::interface(str)</code> to specify the local interface to bind to.</li> <li>Experimental: disables the <code>http3</code> feature temporarily.</li> </ul> <h2>v0.11.27</h2> <ul> <li>Add <code>hickory-dns</code> feature, deprecating <code>trust-dns</code>.</li> <li>(wasm) Fix <code>Form::text()</code> to not set octet-stream for plain text fields.</li> </ul> <h2>v0.11.26</h2> <ul> <li>Revert <code>system-configuration</code> upgrade, which broke MSRV on macOS.</li> </ul> <h2>v0.11.25</h2> <ul> <li>Fix <code>Certificate::from_pem_bundle()</code> parsing.</li> <li>Fix Apple linker errors from detecting system proxies.</li> </ul> <h2>v0.11.24</h2> <ul> <li>Add <code>Certificate::from_pem_bundle()</code> to add a bundle.</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/seanmonstar/reqwest/commit/0720159f6369f54e045a1fd315e0f24b7a0b4a39"><code>0720159</code></a> v0.12.3</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/92096952b7257af6a9eea6f94c5be04c418be0e3"><code>9209695</code></a> Remove duplicate example for ClientBuilder::default_headers (<a href="https://redirect.github.com/seanmonstar/reqwest/issues/2236">#2236</a>)</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/e3a15650d600f3ab1aa2c6f83dc7567a8677337e"><code>e3a1565</code></a> fix: use lower case domain string when using <code>resolve</code> and <code>resolve_to_addrs</code>...</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/b4c491a6ffa10418d8bfaa49fc38f2175312f90c"><code>b4c491a</code></a> feat: allow fine-grained root certs for rustls (<a href="https://redirect.github.com/seanmonstar/reqwest/issues/2232">#2232</a>)</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/cf4295d59d614b1b813cacfe97f186fba952a358"><code>cf4295d</code></a> chore: update winreg to 0.52.0 (<a href="https://redirect.github.com/seanmonstar/reqwest/issues/2226">#2226</a>)</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/db25e802bf9a40782e5aac3505a7f1c76b902dd6"><code>db25e80</code></a> chore: upgrade base64 to 0.22 (<a href="https://redirect.github.com/seanmonstar/reqwest/issues/2224">#2224</a>)</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/13e27b75bfa734f4303173b69bcd59ca72463459"><code>13e27b7</code></a> fix: response body timeout forwards the size hint</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/872af0c7bc2d1128f7120e52e2ccb1c365fb94a7"><code>872af0c</code></a> refactor: upgrade to rustls-pemfile 2 (<a href="https://redirect.github.com/seanmonstar/reqwest/issues/2222">#2222</a>)</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/68a3f5803b03393938c39a3794a5a9e5f5264796"><code>68a3f58</code></a> fix: stop sending content-length: 0 for GET requests (<a href="https://redirect.github.com/seanmonstar/reqwest/issues/2207">#2207</a>)</li> <li><a href="https://github.com/seanmonstar/reqwest/commit/14e46ff8cb7550473c950f3471d049ad2e139d3f"><code>14e46ff</code></a> FromStr trait implementation for Name (<a href="https://redirect.github.com/seanmonstar/reqwest/issues/2212">#2212</a>)</li> <li>Additional commits viewable in <a href="https://github.com/seanmonstar/reqwest/compare/v0.11.14...v0.12.3">compare view</a></li> </ul> </details> <br /> You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- use conventional commits - include GH actions
Git-cliff config which foollows keepchangelog format with mention of contributors and separate block of first-time contributors It will be used for the future releases
Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) from 2.7.1 to 2.7.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/swatinem/rust-cache/releases">Swatinem/rust-cache's releases</a>.</em></p> <blockquote> <h2>v2.7.3</h2> <ul> <li>Work around upstream problem that causes cache saving to hang for minutes.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/Swatinem/rust-cache/compare/v2.7.2...v2.7.3">https://github.com/Swatinem/rust-cache/compare/v2.7.2...v2.7.3</a></p> <h2>v2.7.2</h2> <h2>What's Changed</h2> <ul> <li>Update action runtime to <code>node20</code> by <a href="https://github.com/rhysd"><code>@rhysd</code></a> in <a href="https://redirect.github.com/Swatinem/rust-cache/pull/175">Swatinem/rust-cache#175</a></li> <li>Only key by <code>Cargo.toml</code> and <code>Cargo.lock</code> files of workspace members by <a href="https://github.com/max-heller"><code>@max-heller</code></a> in <a href="https://redirect.github.com/Swatinem/rust-cache/pull/180">Swatinem/rust-cache#180</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/rhysd"><code>@rhysd</code></a> made their first contribution in <a href="https://redirect.github.com/Swatinem/rust-cache/pull/175">Swatinem/rust-cache#175</a></li> <li><a href="https://github.com/max-heller"><code>@max-heller</code></a> made their first contribution in <a href="https://redirect.github.com/Swatinem/rust-cache/pull/180">Swatinem/rust-cache#180</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/Swatinem/rust-cache/compare/v2.7.1...v2.7.2">https://github.com/Swatinem/rust-cache/compare/v2.7.1...v2.7.2</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md">Swatinem/rust-cache's changelog</a>.</em></p> <blockquote> <h2>2.7.3</h2> <ul> <li>Work around upstream problem that causes cache saving to hang for minutes.</li> </ul> <h2>2.7.2</h2> <ul> <li>Only key by <code>Cargo.toml</code> and <code>Cargo.lock</code> files of workspace members.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/Swatinem/rust-cache/commit/23bce251a8cd2ffc3c1075eaa2367cf899916d84"><code>23bce25</code></a> 2.7.3</li> <li><a href="https://github.com/Swatinem/rust-cache/commit/378c8285a4eaf12899d11bea686a763e906956af"><code>378c828</code></a> Work around upstream GitHub issue and update dependencies</li> <li><a href="https://github.com/Swatinem/rust-cache/commit/a22603398250b864f7190077025cf752307154dc"><code>a226033</code></a> 2.7.2</li> <li><a href="https://github.com/Swatinem/rust-cache/commit/d30f1144e884b1fe579845ed7a339c640dff522e"><code>d30f114</code></a> Only key by <code>Cargo.toml</code> and <code>Cargo.lock</code> files of workspace members (<a href="https://redirect.github.com/swatinem/rust-cache/issues/180">#180</a>)</li> <li><a href="https://github.com/Swatinem/rust-cache/commit/b1db5f9d5f9ed685de3a2774c3d3b838d2dde462"><code>b1db5f9</code></a> Update action runtime to <code>node20</code> (<a href="https://redirect.github.com/swatinem/rust-cache/issues/175">#175</a>)</li> <li>See full diff in <a href="https://github.com/swatinem/rust-cache/compare/v2.7.1...v2.7.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from 1.67 to master. You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artem Medvedev <i@ddtkey.com>
Updates the requirements on [axum](https://github.com/tokio-rs/axum) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tokio-rs/axum/releases">axum's releases</a>.</em></p> <blockquote> <h2>axum-extra - v0.7.5</h2> <ul> <li><strong>fixed:</strong> Remove explicit auto deref from <code>PrivateCookieJar</code> example (<a href="https://redirect.github.com/tokio-rs/axum/issues/2028">#2028</a>)</li> </ul> <p><a href="https://redirect.github.com/tokio-rs/axum/issues/2028">#2028</a>: <a href="https://redirect.github.com/tokio-rs/axum/pull/2028">tokio-rs/axum#2028</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tokio-rs/axum/commit/ef8a9e812c1b49b61d21813cb30f5982d8da56df"><code>ef8a9e8</code></a> Release axum and axum-extra (<a href="https://redirect.github.com/tokio-rs/axum/issues/2676">#2676</a>)</li> <li><a href="https://github.com/tokio-rs/axum/commit/c6fd8528446e8738d14a0e6e916acea51f951330"><code>c6fd852</code></a> Update <code>sync_wrapper</code> to 1.0.0 from 0.1.1</li> <li><a href="https://github.com/tokio-rs/axum/commit/2ec68d6c4dab10b83b9195c3acd4ccc7c26d0e8a"><code>2ec68d6</code></a> Add rejection tracing to all extractors (<a href="https://redirect.github.com/tokio-rs/axum/issues/2584">#2584</a>)</li> <li><a href="https://github.com/tokio-rs/axum/commit/2ce382f0ab18bee084b2eda2248d163d79bd8fc7"><code>2ce382f</code></a> Remove h2 from dependencies when http2 feature is off (<a href="https://redirect.github.com/tokio-rs/axum/issues/2605">#2605</a>)</li> <li><a href="https://github.com/tokio-rs/axum/commit/8b13d4cf3c75beed927f08502e87d8f8b505102d"><code>8b13d4c</code></a> Add axum-typed-routing to ECOSYSTEM.md (<a href="https://redirect.github.com/tokio-rs/axum/issues/2608">#2608</a>)</li> <li><a href="https://github.com/tokio-rs/axum/commit/19f6f7900f4997c23dfe978c7e903211f98a624c"><code>19f6f79</code></a> Fix layers being cloned for each request (<a href="https://redirect.github.com/tokio-rs/axum/issues/2586">#2586</a>)</li> <li><a href="https://github.com/tokio-rs/axum/commit/3569950a2e5a8ccee481a1b7632638a976a0cd7d"><code>3569950</code></a> Make nightly_error_messages feature compatible with latest nightly</li> <li><a href="https://github.com/tokio-rs/axum/commit/b6b203b3065e4005bda01efac8429176da055ae2"><code>b6b203b</code></a> fix typo in prometheus_metrics_example (<a href="https://redirect.github.com/tokio-rs/axum/issues/2627">#2627</a>)</li> <li><a href="https://github.com/tokio-rs/axum/commit/b03f6c1184723bdc079215222fc168ef96847dea"><code>b03f6c1</code></a> Fix typo in CONTRIBUTING.md (<a href="https://redirect.github.com/tokio-rs/axum/issues/2612">#2612</a>)</li> <li><a href="https://github.com/tokio-rs/axum/commit/4d65ba0215b57797193ec49245d32d4dd79bb701"><code>4d65ba0</code></a> ci: Unbreak cargo-deny action (<a href="https://redirect.github.com/tokio-rs/axum/issues/2613">#2613</a>)</li> <li>Additional commits viewable in <a href="https://github.com/tokio-rs/axum/compare/axum-v0.6.20...axum-v0.7.5">compare view</a></li> </ul> </details> <br /> You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artem Medvedev <i@ddtkey.com>
Use cargo-hack instead of matrix to minimize number of GH jobs and make it more comprehensive (each feature is tested)
Inside of the Matrix channel, it is mentioned that the official contact channel is now Slack. --------- Co-authored-by: Artem Medvedev <i@ddtkey.com>
Closes #554. This PR allows to an alternative way of creating a `RunnableImage` with other than default args. This can already be done with a tuple, but it is kind of "hidden" https://github.com/testcontainers/testcontainers-rs/blob/71bbdec013c1b19e5507217d52c612c71d9473f5/testcontainers/src/core/image.rs#L325 What could be done before: ```rust let image = (GenericImage,vec!["one-arg","another-arg"]); let runnable_image = RunnableImage::from(image) ``` Now: ```rust let runnable_image = RunnableImage::from(GenericImage).with_args(vec!["one-arg","another-arg"]); ``` Furthermore, it is more consistent now, since all of the `RunnableImage` attributes but the `image_args` could be modified using a `with_*` method.
This change allows to override name of the image. Thus, user will be able to change registry, owner and the name itself. See #335 (comment) for more details Closes #335
Quite large refactoring as part of project revamp #563, and also the long-awaited refactoring #386 Now it's really simple API, e.g: ```rs let container = GenericImage::new("redis", "latest") .with_exposed_port(6379) .with_wait_for(WaitFor::message_on_stdout("Ready to accept connections")) .start(); ``` I find this new API much easier to use, solves a lot of problems, and seems flexible enough to be extended. This also works regardless of the tokio runtime flavor (multi-thread vs current-thread). And the sync API is still available, right under `blocking` feature (just like `reqwest` does). From a maintainer's perspective this also simplifies the code, we don't have to worry about two different clients and their differences. ### Docker host resolution The host is resolved in the following order: 1. Docker host from the `tc.host` property in the `~/.testcontainers.properties` file. 2. `DOCKER_HOST` environment variable. 3. Docker host from the "docker.host" property in the `~/.testcontainers.properties` file. 4. Else, the default Docker socket will be returned. ### Notes - MSRV was bumped to `1.70` in order to use `std::sync::OnceLock`. This should NOT be a problem, tests usually executed on more recent versions (also see [this ref](https://github.com/testcontainers/testcontainers-rs/pull/503/files#r1242651354)). - `Cli` client is removed, instead we provide `sync` (under `blocking` feature) and `async` impls based on HTTP client (bollard) - tested with [modules](https://github.com/testcontainers/testcontainers-rs-modules-community) ## Migration guide - Sync API migration (`Cli` client) - Add `blocking` feature - Drop all usages of `clients::Cli` - Add `use testcontainers::runners::SyncRunner;` - Replace `client.run(image)` with `image.start()` - Async API migration (`Http` client) - Remove `experimental` feature - Drop all usages of `clients::Http` - Add `use testcontainers::runners::AsyncRunner;` - Replace `client.run(image)` with `image.start()` ## References Closes #386 Closes #326 Closes #475 Closes #508 Closes #392 Closes #561 Closes #559 Closes #564 Closes #538 Closes #507 Closes #89 Closes #198
It can be useful in some cases to ensure all images are pulled before execution. For example, to minimize startup time of container
The volumes option is used for anonymous volumes, whereas the binds is
the one that accepts a list of `{local}:{remote}` paths.
Fixes #580.
`dprint` looks like a fantastic tool, but it is not very widely used, has some problems and introduces difficulties for newcomers and maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )