Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤏 erc20: Init immutables don't hafta to be constructored #379

Open
wants to merge 50 commits into
base: v7
Choose a base branch
from

Conversation

z0r0z
Copy link
Contributor

@z0r0z z0r0z commented Aug 2, 2023

Thoughts towards style and reducing LOC?

Description

Describe the changes made in your pull request here.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@transmissions11
Copy link
Owner

huh yeah why didnt we do this all along?

@transmissions11
Copy link
Owner

can you target this to v7? im scared to merge anything into master rn

@z0r0z z0r0z changed the base branch from main to v7 August 3, 2023 17:47
@z0r0z
Copy link
Contributor Author

z0r0z commented Aug 3, 2023

cool yea I think gtg!

@transmissions11
Copy link
Owner

for some reason there are a zillion conflicts lol

@z0r0z
Copy link
Contributor Author

z0r0z commented Aug 4, 2023

for some reason there are a zillion conflicts lol

yea what the hell lol

basically, the change is very smol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet