Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-12535 - MV-rebase/dependabot/go modules/GitHub.com/vektra/mockery/v2 2.13.1 #8859

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2022

Jira ticket for this change

Summary

There are essentially two types of changes in this pr:

  1. Dependency updates related to a mockery upgrade
  2. Many changes to generated mock files in which interfaces are added or renamed to fit a new pattern described in this PR

Though the number of files changed seems alarming, the changes also seem pretty harmless and the tests are still passing.

Rebased #8769, description copied below:

Bumps github.com/vektra/mockery/v2 from 2.12.2 to 2.13.1.

Release notes

Sourced from github.com/vektra/mockery/v2's releases.

v2.13.1

Changelog

  • f04b040 Fix infinity mocking caused interface in mock
  • 9d7c819 Merge pull request #472 from grongor/fix-infinite-mocking

v2.13.0

Changelog

  • f9f6d38 Merge pull request #477 from LandonTClipp/generics_release
  • 6498bd6 Updating dependencies

v2.13.0-beta.1

Changelog

  • 9dba1fd Merge pull request #454 from Gevrai/gejo-move-expecter-test
  • cde38d9 Move generated ExpecterTest to mocks directory

v2.13.0-beta.0

Changelog

  • dc5539e Add support for generating mocks for generic interfaces
  • 33c4bf3 Generics mocking fixes
  • a727d70 Genrics support: rename and comment methods
  • 4c0f6c8 Merge conflict resolution
  • 46c61f0 Merge pull request #456 from cruickshankpg/mock-generic-interfaces
  • ed55a47 Update x/tools to pick up fix for golang/go#51629

v2.12.3

Changelog

  • 41e99e1 Add explicit generation for ExpecterTest
  • 68d25fe Merge pull request #466 from LandonTClipp/testing_tb
  • 356a8cd Reduce size of interface passed to mock constructor
  • b338b68 Updating mocks and fixing tests/behavior
Commits
  • 9d7c819 Merge pull request #472 from grongor/fix-infinite-mocking
  • f04b040 Fix infinity mocking caused interface in mock
  • f9f6d38 Merge pull request #477 from LandonTClipp/generics_release
  • 6498bd6 Updating dependencies
  • 9dba1fd Merge pull request #454 from Gevrai/gejo-move-expecter-test
  • cde38d9 Move generated ExpecterTest to mocks directory
  • 46c61f0 Merge pull request #456 from cruickshankpg/mock-generic-interfaces
  • 4c0f6c8 Merge conflict resolution
  • ed55a47 Update x/tools to pick up fix for golang/go#51629
  • a727d70 Genrics support: rename and comment methods
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@robot-mymove
Copy link

robot-mymove commented Jul 6, 2022

Messages
📖 🔗 MB-12535

Generated by 🚫 dangerJS against 90a8619

dependabot bot and others added 3 commits July 6, 2022 22:34
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.12.2 to 2.13.1.
- [Release notes](https://github.com/vektra/mockery/releases)
- [Changelog](https://github.com/vektra/mockery/blob/master/.goreleaser.yml)
- [Commits](vektra/mockery@v2.12.2...v2.13.1)

---
updated-dependencies:
- dependency-name: github.com/vektra/mockery/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@ghost ghost force-pushed the mv-rebase/dependabot/go_modules/github.com/vektra/mockery/v2-2.13.1 branch from 05fe25f to f2a179f Compare July 6, 2022 22:34
@ghost ghost changed the title Mv rebase/dependabot/go modules/GitHub.com/vektra/mockery/v2 2.13.1 MB-12535 - MV-rebase/dependabot/go modules/GitHub.com/vektra/mockery/v2 2.13.1 Jul 6, 2022
@ghost ghost self-requested a review July 6, 2022 22:56
@ghost ghost added dependencies Pull requests that update a dependency file Pamplemoose labels Jul 6, 2022
@ghost ghost marked this pull request as ready for review July 6, 2022 22:56
Copy link
Contributor

@rogeruiz rogeruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌈

Nice catch on the interface changes here. Glad to see the improvement, @michaelvaldes-truss

@mergify mergify bot merged commit aecd156 into master Jul 11, 2022
@mergify mergify bot deleted the mv-rebase/dependabot/go_modules/github.com/vektra/mockery/v2-2.13.1 branch July 11, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready-to-merge
Development

Successfully merging this pull request may close these issues.

None yet

2 participants