-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT B-19903 unlocking a move #12677
Merged
danieljordan-caci
merged 8 commits into
integrationTesting
from
INT-B-19903-unlocking-a-move
May 15, 2024
Merged
INT B-19903 unlocking a move #12677
danieljordan-caci
merged 8 commits into
integrationTesting
from
INT-B-19903-unlocking-a-move
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
added
Mountain Movers
Movin' Mountains 1 Sprint at a time
INTEGRATION
Slated for Integration Testing
labels
May 14, 2024
danieljordan-caci
requested review from
deandreJones,
TevinAdams,
cameroncaci,
paulstonebraker and
traskowskycaci
May 14, 2024 21:01
cameroncaci
reviewed
May 15, 2024
cameroncaci
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 comments, 1 a request to add err
and user to logger, and another to just ask a question
…ng-a-move' into INT-B-19903-unlocking-a-move
traskowskycaci
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked exactly as expected and looks neat. Nice!
cameroncaci
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
When setting up the functionality of an office user locking a move when they navigate into it, this sets the stage for when an office user needs to unlock that move. Currently there are two ways an office user can unlock a move:
MovesQueue
, TIO ->PaymentRequestQueue
, SC ->ServicesCounselingQueue
)This PR does the following:
UnlockMove
andCheckForLockedMovesAndUnlock
to be run for each scenario of an office user unlocking a moveUnlockMove
when checks returntrue
when loading up the queue listcheckForLockedMovesAndUnlock
when an office user logs outHow to test
This is a little tricky to test, so it is best to use two browsers that don't share cookies (I use one Chrome and one Safari - you could also do an incognito browser and one not)
server
&client
, in yourenvrc
changeFEATURE_FLAG_MOVE_LOCK=true
make server_run
andmake client_run