B 19976 int #12676
Merged
B 19976 int #12676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoryKleinjanCACI
added
Scrummy Bears
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
ajlusk
reviewed
May 15, 2024
| @@ -48,6 +48,7 @@ const serviceItemCodes = { | |||
| MS: 'Move management', | |||
| NSTH: 'Nonstandard HHG', | |||
| NSTUB: 'Nonstandard UB', | |||
| DCRTSA: 'Domestic Standalone Crating', | |||
There was a problem hiding this comment.
There's a double space here. Seems unintentional.
ajlusk
reviewed
May 15, 2024
swagger-def/definitions/prime/MTOServiceItemDomesticStandaloneCrating.yaml
Outdated
Show resolved
Hide resolved
ajlusk
approved these changes
May 15, 2024
MInthavongsay
approved these changes
May 17, 2024
| primemessages.MTOServiceItemModelTypeMTOServiceItemDestSIT: true, | ||
| primemessages.MTOServiceItemModelTypeMTOServiceItemShuttle: true, | ||
| primemessages.MTOServiceItemModelTypeMTOServiceItemDomesticCrating: true, | ||
| primemessages.MTOServiceItemModelTypeMTOServiceItemOriginSIT: true, |
There was a problem hiding this comment.
Confirm if you really need to update V1 for Prime. Any v1 API(s) using it?
r-mettler
approved these changes
May 17, 2024
CoryKleinjanCACI
requested review from
ajlusk
and removed request for
antgmann and
ajlusk
CoryKleinjanCACI
removed
Scrummy Bears
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
19976
Summary
This task adds the ability for the prime to add a 'Standalone Crate' item to a move. Its functionality is nearly identical to a standard crating item, with the caveat that when the TOO goes to approve the item, the highest dollar amount that can be approved is 1000$. The TOO approval is part of a follow-on task and is not completed here.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Prime Sim:
Swagger/ Postman:
Swagger URL: http://primelocal:3000/swagger-ui/prime.html#/mtoServiceItem/createMTOServiceItem
Payload: {"item":{"length":4,"width":4,"height":4},"crate":{"length":5,"width":5,"height":5},"moveTaskOrderID":"958776a4-782f-4657-bd29-0e7f5cf5bedc","mtoShipmentID":"67d0fd70-eba3-4455-83b8-ab658bc8099f","modelType":"MTOServiceItemDomesticStandaloneCrating","reason":"i want to","description":"moped","reServiceCode":"DCRTSA"}
Backend
Database
Any new migrations/schema changes:
Screenshots