Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN B-19882 backend ghc update customers to be non cac users #12672

Conversation

danieljordan-caci
Copy link
Contributor

INTEGRATION PR

Agility ticket

Summary

With the future work of E-05384, we want to set the backend up to be able to consider the cac_validated value when an office user can update a customer so they can designate if they are a non-CAC holder or not. This will bypass the CAC registration when a customer initially signs into MilMove.

This PR does the following:

  • updates swagger & backend to receive cac_validated value when performing the GET request to retrieve a customer's profile information
  • updates swagger & backend to send cac_validated value when performing the POST request to update a customer's profile information
  • updated relevant tests

How to test

  1. Fire up client and server and log in as a TOO
  2. Head on over to http://officelocal:3000/swagger-ui/ghc.html#/customer/getCustomer or you can use Postman and query a service member of your choice.
    If they have cac_validated as true in the database, it should appear in the response body. If it is false, it will not appear (this is because we don't have x-nullable set up in swagger).
  3. Now head on over to http://officelocal:3000/swagger-ui/ghc.html#/customer/updateCustomer and put in the If-Match as well as the service member's id, and have this as your body:
{
  "cac_validated": true
}
  1. You should now get a successful response, meaning we can use this in the UI in future stories and send that through the response and the office users will be able to view and update a service member if they are a non-CAC user

@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time MAIN labels May 14, 2024
@danieljordan-caci danieljordan-caci self-assigned this May 14, 2024
@danieljordan-caci danieljordan-caci requested a review from a team as a code owner May 14, 2024 19:13
@danieljordan-caci danieljordan-caci changed the title Main b 19882 backend ghc update customers to be non cac users MAIN B-19882 backend ghc update customers to be non cac users May 14, 2024
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches up!

@deandreJones deandreJones merged commit eae5bdf into main May 15, 2024
38 checks passed
@deandreJones deandreJones deleted the MAIN-B-19882-backend-ghc-update-customers-to-be-non-cac-users branch May 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAIN Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

None yet

5 participants