-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-19882 backend ghc update customers to be non cac users #12672
Merged
deandreJones
merged 7 commits into
main
from
MAIN-B-19882-backend-ghc-update-customers-to-be-non-cac-users
May 15, 2024
Merged
MAIN B-19882 backend ghc update customers to be non cac users #12672
deandreJones
merged 7 commits into
main
from
MAIN-B-19882-backend-ghc-update-customers-to-be-non-cac-users
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
added
Mountain Movers
Movin' Mountains 1 Sprint at a time
MAIN
labels
May 14, 2024
danieljordan-caci
requested review from
deandreJones,
TevinAdams,
cameroncaci,
traskowskycaci and
MichaelEngelbertCACI
May 14, 2024 19:13
danieljordan-caci
changed the title
Main b 19882 backend ghc update customers to be non cac users
MAIN B-19882 backend ghc update customers to be non cac users
May 14, 2024
traskowskycaci
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches up!
TevinAdams
approved these changes
May 14, 2024
…-be-non-cac-users
cameroncaci
approved these changes
May 15, 2024
…-be-non-cac-users
…-be-non-cac-users
…-be-non-cac-users
deandreJones
approved these changes
May 15, 2024
deandreJones
approved these changes
May 15, 2024
deandreJones
deleted the
MAIN-B-19882-backend-ghc-update-customers-to-be-non-cac-users
branch
May 15, 2024 15:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INTEGRATION PR
Agility ticket
Summary
With the future work of E-05384, we want to set the backend up to be able to consider the
cac_validated
value when an office user can update a customer so they can designate if they are a non-CAC holder or not. This will bypass the CAC registration when a customer initially signs into MilMove.This PR does the following:
cac_validated
value when performing theGET
request to retrieve a customer's profile informationcac_validated
value when performing thePOST
request to update a customer's profile informationHow to test
client
andserver
and log in as a TOOhttp://officelocal:3000/swagger-ui/ghc.html#/customer/getCustomer
or you can use Postman and query a service member of your choice.If they have
cac_validated
astrue
in the database, it should appear in the response body. If it is false, it will not appear (this is because we don't havex-nullable
set up in swagger).http://officelocal:3000/swagger-ui/ghc.html#/customer/updateCustomer
and put in theIf-Match
as well as the service member'sid
, and have this as your body: