Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-19680 UI customer ppm shipment summary - ZIP to Address #12660

Merged

Conversation

MInthavongsay
Copy link
Contributor

B-19680

Summary

INTEGRATION

This PR is part of the EPIC to fully convert from using standalone zip codes to using full addresses for PPM onboarding. The changes for this PR is only for the review page .

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Log in as customer and onboard PPMs
  2. Start adding PPMs and review the display of PPMs. Note standalone ZIP codes are now labeled as Address. Addresses are displayed as one single string. Secondary addresses will only be visible if exist.

Screenshot 2024-05-13 at 1 28 06 PM

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

@MInthavongsay MInthavongsay added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels May 13, 2024
@MInthavongsay MInthavongsay self-assigned this May 13, 2024
@MInthavongsay MInthavongsay requested a review from a team as a code owner May 13, 2024 17:39
@MInthavongsay MInthavongsay changed the base branch from main to integrationTesting May 13, 2024 18:00
@r-mettler
Copy link
Contributor

I see the full address on the PPM card.
image

Dockerfile Outdated Show resolved Hide resolved
swagger-def/internal.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above comments resolved.

@r-mettler r-mettler merged commit 1c19538 into integrationTesting May 16, 2024
30 checks passed
@r-mettler r-mettler deleted the INT-B-19680-UI-Customer-PPM-shipment-summary branch May 16, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

None yet

3 participants