Fix potential version mismatch in v2.10 update instructions #10712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Can you rebase your branch against the branch |
|
While rebasing the branch I noticed that this is fixed in #10658. But for some reason this has not reflected in the documentation website. That PR was made directly to the v2.11 branch and when I rebase my PR, the change is already there. I think we can close this PR and look into why the v2.11 branch is not deployed yet. CC: @stemar94 |
|
Duplicate of #10658 It will backported to v3.0 and master when we will do the merge back of the branch v2.11 |
ldez
added
resolution/duplicate
and removed
area/documentation
contributor/waiting-for-corrections
status/0-needs-triage
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a potential error in the docs for instructions to upgrade to Traefik v2.10.
Motivation
It is mentioned that
traefik.io/v1alpha1API group will not be supported in Traefik v3. I believe this was supposed to betraefik.containo.us/v1alpha1since that API group is getting deprecated in v2.10 and later removed in v3.0. The upgradation instruction can be misleading for users trying to upgrade to v2.10 before upgrading to v3.More
Additional Notes
Please let me know if I should change the base branch of the PR to v2.11 branch. When I had tried that as per the instruction in the PR, I saw a lot of changes show up in my PR.