Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display of Content Security Policy values getting out of screen #10710

Merged
merged 2 commits into from May 17, 2024
Merged

Display of Content Security Policy values getting out of screen #10710

merged 2 commits into from May 17, 2024

Conversation

brandonfl
Copy link
Contributor

@brandonfl brandonfl commented May 11, 2024 •
edited by kevinpollet

What does this PR do?

Fix the CSP display that can get out of the screen on the webui.

Old :

csp-old-display

Fixed :

csp-new-display

Motivation

Related to #10246

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 3.0 milestone May 11, 2024
@brandonfl brandonfl changed the title Fix : Display of security-header values getting out of screen Fix : Display of SCP values getting out of screen May 11, 2024
@ldez ldez changed the title Fix : Display of SCP values getting out of screen Display of SCP values getting out of screen May 11, 2024
@nmengin
Copy link
Contributor

nmengin commented May 13, 2024

Hey @brandonfl,

Thank you for your contribution.

@gndz07 @mdeliatf I'd like your opinion on it please.

@nmengin nmengin added the kind/bug/fix a bug fix label May 13, 2024
@kevinpollet kevinpollet changed the base branch from v3.0 to v2.11 May 17, 2024 12:16
@kevinpollet kevinpollet changed the title Display of SCP values getting out of screen Display of Content Security Policy values getting out of screen May 17, 2024
kevinpollet
kevinpollet approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kevinpollet kevinpollet modified the milestones: 3.0, 2.11 May 17, 2024
nmengin
nmengin approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @brandonfl,

Thank you for your contribution.
LGTM

ldez
ldez approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 4292059 into traefik:v2.11 May 17, 2024
22 checks passed
@kevinpollet kevinpollet mentioned this pull request May 17, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/webui kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brandonfl @nmengin @kevinpollet @ldez @traefiker