Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI unit tests #10665

Merged

Conversation

framebassman
Copy link
Contributor

@framebassman framebassman commented Apr 29, 2024

What does this PR do?

This PR fixes UI tests

Motivation

#10640

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@framebassman
Copy link
Contributor Author

@gndz07 and @mdeliatf pls review

@framebassman
Copy link
Contributor Author

@nmengin could you ask your UI guys to review this, pls?

@nmengin
Copy link
Contributor

nmengin commented May 2, 2024

Hey @framebassman,

Thank you for rebasing your PR.
I talked about it with @gndz07 and @mdeliatf, they have planned to review it later this month.

@ldez ldez changed the title Fix UI unit tests 2.11 Replace mocha by vitest May 2, 2024
@framebassman framebassman changed the title Replace mocha by vitest Fix UI unit tests May 7, 2024
@mdeliatf
Copy link
Contributor

LGTM!

@framebassman
Copy link
Contributor Author

@mdeliatf could you pls mark this PR as approved from you?

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @framebassman,

Thank you for your contribution.

LGTM 🎉

FYI as @mdeliatf is not a Traefik maintainer, he can not leave an approval.

@nmengin nmengin added the kind/bug/fix a bug fix label May 21, 2024
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit d4d23dc into traefik:v2.11 May 21, 2024
22 checks passed
@framebassman framebassman deleted the feature/vitest-fix-unit-tests-2.11 branch May 21, 2024 13:31
@framebassman
Copy link
Contributor Author

@nmengin I suppose we need to close the #10640

@framebassman framebassman mentioned this pull request May 21, 2024
2 tasks
@nmengin
Copy link
Contributor

nmengin commented May 21, 2024

Indeed @framebassman, thanks again for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants