[poc] middlewares: tcp: add rate limit #10468
Draft
+215
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>
dsseng
changed the title
|
It's actually not mergeable, but requires a design review from maintainers to proceed. Are draft PRs reviewed? |
|
By default, draft PRs are not reviewed. |
|
any news on this feature ? is it being implemented ? |
|
Design needs to be reviewed by maintainers, as I want to be sure the feature is correctly implemented and only then document it and fulfill all the requirements |
|
ok, by the way is this rate limit working only on a number of session basis or can it work also on a tot. number of transmitted byte basis ? |
|
The thing I did limits connection attempts, not amount of data transmitted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a TCP rate limiter based on the HTTP one (I couldn't find what to improve to better fit TCP). It limits
Motivation
Fixes #5999
More
Additional Notes
Previous PRs in this direction were declined, so I'm not sure what else should be done to properly adapt to TCP. This implementation seems fine, only filtering connection attempts