Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade project to node 18 and react 18 #392

Merged
merged 7 commits into from
Dec 16, 2022

Conversation

paulocfjunior
Copy link
Contributor

  • Upgraded Node to v18
  • Upgraded React to v18
  • Upgrade Husky and reconfigure hooks
  • Set .nvmrc for ease of use

package.json Outdated Show resolved Hide resolved
@gndz07
Copy link
Member

gndz07 commented Dec 14, 2022

I found it weird that it still gives this warning:

image

According to this, storybook v6.5 should have been supporting the root API out of the box 🤔
Do you get the same warning? If it really is behaving as if still running on React v17, I think it won't really solve the rehydration problem on SSR.

Copy link
Member

@gndz07 gndz07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker
Copy link
Contributor

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants