Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropType<T>を使う refs #101 #213

Merged
merged 2 commits into from Apr 10, 2020
Merged

PropType<T>を使う refs #101 #213

merged 2 commits into from Apr 10, 2020

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Apr 2, 2020

試しに書き換えてみたんですが、たぶんよさげです

よろしくお願いします

refs #101 #232

@sapphi-red sapphi-red changed the title PropType<>を使う refs #101 PropType<T>を使う refs #101 Apr 2, 2020
@sapphi-red sapphi-red force-pushed the fix/props branch 2 times, most recently from 72ddf13 to 69034cd Compare April 6, 2020 15:47
@sapphi-red sapphi-red requested a review from spaspa April 6, 2020 15:50
@sapphi-red sapphi-red marked this pull request as ready for review April 6, 2020 15:50
Copy link
Member

@spaspa spaspa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:kansya:
ガッと入れてしまいたい

@@ -6,7 +6,11 @@ module.exports = {
parserOptions: {
parser: '@typescript-eslint/parser'
},
extends: ['plugin:vue/essential', '@vue/prettier', '@vue/typescript'],
extends: [
'plugin:vue/strongly-recommended',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
https://qiita.com/ota-meshi/items/ff0d70ef326657249727 あたりもやっていきたいですね

@sapphi-red sapphi-red merged commit a0eac31 into master Apr 10, 2020
@sapphi-red sapphi-red deleted the fix/props branch April 10, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants