Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/go version update #1066

Merged
merged 7 commits into from Aug 5, 2023
Merged

Chore/go version update #1066

merged 7 commits into from Aug 5, 2023

Conversation

kaitoyama
Copy link
Contributor

@kaitoyama kaitoyama commented Aug 5, 2023

#1046 の対応です
Goのバージョンを1.17から1.20.7に上げました。

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (392395c) 60.41% compared to head (1d78e2c) 60.41%.

❗ Current head 1d78e2c differs from pull request most recent head 78f340b. Consider uploading reports for the commit 78f340b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files          20       20           
  Lines        2981     2981           
=======================================
  Hits         1801     1801           
  Misses       1020     1020           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xxarupakaxx xxarupakaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/traPtitech/anke-to/blob/main/Dockerfile
あとここのDockerfileの修正もお願いします!

@kaitoyama
Copy link
Contributor Author

kaitoyama commented Aug 5, 2023

DockerFile修正しました。
上のTestでFAILしているのはTestQuestions/GetQuestionsで、これは #577 でFlakyなテストとして報告されているので問題ないと思います。

Copy link
Contributor

@xxarupakaxx xxarupakaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arigatougozaiasmu!

@kaitoyama kaitoyama merged commit afe1ac4 into main Aug 5, 2023
5 of 7 checks passed
@kaitoyama kaitoyama deleted the chore/go_version_update branch August 5, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants