Add support for enumerate #1522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niqodea
reviewed
Oct 18, 2023
Comment on lines
-979
to
+982
| total = len(iterable) | ||
| if isinstance(iterable, enumerate): | ||
| total = len(list(iterable)) | ||
| else: | ||
| total = len(iterable) |
There was a problem hiding this comment.
I am not sure this change will be approved. By calling list on the enumerate iterable you are potentially loading an entire dataset into memory, and also consuming the iterable.
There was a problem hiding this comment.
You could extract the wrapped iterable and work with that instead.
There was a problem hiding this comment.
Anyhow, the standard way to use tqdm together with enumerate is to wrap with tqdm first and enumerate second:
enumerate(tqdm(iterable))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the use of "enumerate" as iterable of tqdm. With this feature, tqdm automatically compute the total number of iterations when the argument of tqdm is of type "enumerate"