Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows wrong finish statusbar behaviour #1337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: windows wrong finish statusbar behaviour #1337

wants to merge 1 commit into from

Conversation

MrJack91
Copy link

fix: windows wrong finish statusbar behaviour

@MrJack91
Update std.py
74693a1 
fix: windows wrong finish statusbar behaviour
@MrJack91 MrJack91 requested a review from casperdcl as a code owner June 29, 2022 07:15
@MrJack91 MrJack91 mentioned this pull request Jun 29, 2022
Open
@MrJack91
Copy link
Author

The corresponding issue: #1336

@MrJack91 MrJack91 changed the title Update std.py fix: windows wrong finish statusbar behaviour Jun 29, 2022
@mjpieters
Copy link

This is not the right solution, unfortunately. Completed progress bars are explicitly pushed to the top to minimize updating (see #677 for why this happens). Your patch reverts this behaviour.

See #1502 for the right approach, which is to adjust the pos values of the remaining progress bars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl Awaiting requested review from casperdcl casperdcl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MrJack91 @mjpieters